Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false MissingOverrideAttribute issue #10989

Open
wants to merge 5 commits into
base: 5.x
Choose a base branch
from

Conversation

ghostwriter
Copy link

This patch resolves #10982, via the following changes:

  • Add test case tests/OverrideTest.php
  • Update src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php

ghostwriter and others added 2 commits May 23, 2024 20:18
Co-Authored-By: Philip Hofstetter <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
ghostwriter and others added 3 commits May 26, 2024 22:08
Signed-off-by: Nathanael Esayeas <[email protected]>
Co-Authored-By: Evan Shaw <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Co-Authored-By: Tim Düsterhus <[email protected]>
Copy link
Contributor

@edsrzf edsrzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not a maintainer, so we need to wait for one before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MissingOverrideAttribute false positive with traits used by child classes
2 participants